Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark examplelibs as non-transitive, enable javadoc and sources for all #378

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

tonihele
Copy link
Contributor

@tonihele tonihele commented Sep 10, 2022

This fixes #368, fixes #283.

Mark the examplelibs configuration to only contain itself, since we actually ship the dependencies to the created project. This library is used only to copy its sources to the project template.

What do you think @MeFisto94 ?

@MeFisto94
Copy link
Member

good catch with the transitive = false. The false, false were coming from me where we still manually built the engine and thus it was not working, but due to us being back on maven central releases, that works again. Nice

@tonihele tonihele merged commit f98d73d into jMonkeyEngine:master Sep 12, 2022
@tonihele tonihele deleted the issue-368 branch September 12, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants