Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#303 dark app icons #437

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Conversation

neph1
Copy link
Contributor

@neph1 neph1 commented Nov 29, 2022

After some trial and error I realized it affected the "dark" themes, which supposedly use nb dark mode. Then I found this thread:
JFormDesigner/FlatLaf#424

Fixes #303

@tonihele
Copy link
Contributor

Nice work! Does it also need the larger icons?

@neph1
Copy link
Contributor Author

neph1 commented Nov 29, 2022

I'd say it doesn't, based on the output from xprop. But who knows? 🤷
Also, it seems like at least mint doesn't use larger icons than 48px.
My knowledge in the field is limited. But I guess we can always create a new issue if it becomes a problem in the future :)

Edit: Or wait, what do you mean with "larger"? I interpreted it as "beyond 48px"

@neph1 neph1 modified the milestone: 3.x release Nov 29, 2022
@tonihele
Copy link
Contributor

Or wait, what do you mean with "larger"? I interpreted it as "beyond 48px"

Yes, interpreted correctly.

@tonihele tonihele self-requested a review November 29, 2022 21:27
@neph1 neph1 merged commit 46054c6 into jMonkeyEngine:master Nov 30, 2022
@neph1 neph1 deleted the Fix_#303_dark_app_icons branch May 6, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JME3 Launcher looks great on the desktop, but once JME3 is running it has the Netbeans logo on Ubuntu
2 participants