Gradle wizard searching Maven central for latest versions #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ok, this is kinda ridiculous demand. We can fix this to be better... |
…ould happen... reduce the log level
|
I also reduced the log level to INFO. It is better UX I think. Errors are to be expected.. to some degree. With INFO they still come to the application log and all. So maybe it is enough. Now they don't bother the user. |
|
I'll merge this in 12h if no objections. I think it is production ready. I still tweaked the version handling to more straightforward model in code. |
tonihele
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #371
Alright.. Now, if Maven API is up, we initialize the user project with latest versions of libraries. And automatically display latest versions of jME to choose from. If Maven API is down, it doesn't matter, we have a set of hard coded versions to choose from. This is just an enhancement that is provided for our and users' convenience.
Maven API wasn't working that great this past two weeks. Now it seems to be up again. How this is designed, is that there is zero wait for the user. So there might be inconsistent results in users' perspective as we might catch latest versions at some random point in time.
In my experience, the Maven API either responds immediately or it is simply down. Meaning that this strategy is viable. The Maven is accessed in highly parallel way, zero locks still. And only once per lifetime of the SDK instance.
Ok, the caveats:
test-dataandawt-dialogsmight be missing from some versions, yet they are hard coded to be included (not the latter, yet)edit: added library version filtering to avoid weird version types (minie and heart)