Fix Windows installer #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #491 Yeah, I tested this. NB Installer (NBI) seems to check for unpack200.exe from the bundled JDK. It checks this before it even looks that is there anything to unpack. We don't, at least not anymore. All the pack200 are now turned off. The fake unpacker needs to be bundled until NBI is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pack200 was removed with Java 14. We are on Java 17. No-go. I did not test this but looks like the Windows installer falls to using the bundled JDK (17) to try unpack pack200 and fails. I have no idea why it works on Linux.