Skip to content

Commit

Permalink
Replace ArrayList<ExecuteListener> by ExecuteListener[] in ExecuteLis…
Browse files Browse the repository at this point in the history
…teners to avoid excessive Iterator creation
  • Loading branch information
lukaseder committed Jan 14, 2015
1 parent 5163c4a commit e248376
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions jOOQ/src/main/java/org/jooq/impl/ExecuteListeners.java
Expand Up @@ -63,15 +63,15 @@ class ExecuteListeners implements ExecuteListener {
/** /**
* Generated UID * Generated UID
*/ */
private static final long serialVersionUID = 7399239846062763212L; private static final long serialVersionUID = 7399239846062763212L;


private final List<ExecuteListener> listeners; private final ExecuteListener[] listeners;


// In some setups, these two events may get mixed up chronologically by the // In some setups, these two events may get mixed up chronologically by the
// Cursor. Postpone fetchEnd event until after resultEnd event, if there is // Cursor. Postpone fetchEnd event until after resultEnd event, if there is
// an open Result // an open Result
private boolean resultStart; private boolean resultStart;
private boolean fetchEnd; private boolean fetchEnd;


ExecuteListeners(ExecuteContext ctx) { ExecuteListeners(ExecuteContext ctx) {
listeners = listeners(ctx); listeners = listeners(ctx);
Expand All @@ -82,7 +82,7 @@ class ExecuteListeners implements ExecuteListener {
/** /**
* Provide delegate listeners from an <code>ExecuteContext</code> * Provide delegate listeners from an <code>ExecuteContext</code>
*/ */
private static List<ExecuteListener> listeners(ExecuteContext ctx) { private static ExecuteListener[] listeners(ExecuteContext ctx) {
List<ExecuteListener> result = new ArrayList<ExecuteListener>(); List<ExecuteListener> result = new ArrayList<ExecuteListener>();


for (ExecuteListenerProvider provider : ctx.configuration().executeListenerProviders()) { for (ExecuteListenerProvider provider : ctx.configuration().executeListenerProviders()) {
Expand All @@ -98,7 +98,7 @@ private static List<ExecuteListener> listeners(ExecuteContext ctx) {
result.add(new StopWatchListener()); result.add(new StopWatchListener());
} }


return result; return result.toArray(new ExecuteListener[result.size()]);
} }


@Override @Override
Expand Down

0 comments on commit e248376

Please sign in to comment.