Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code generator should properly qualify H2 domain enums - Merge [#13936] #14401

Closed
lukaseder opened this issue Dec 13, 2022 · 3 comments
Closed

Code generator should properly qualify H2 domain enums - Merge [#13936] #14401

lukaseder opened this issue Dec 13, 2022 · 3 comments
Labels
C: Code Generation C: DB: H2 E: All Editions P: Medium R: Fixed T: Enhancement
Milestone
Version 3.17.7

Comments

@lukaseder
Copy link
Member

No description provided.

@lukaseder lukaseder added this to the Version 3.17.7 milestone Dec 13, 2022
@lukaseder lukaseder mentioned this issue Dec 13, 2022
Closed
2 tasks
@lukaseder lukaseder reopened this Dec 16, 2022
@lukaseder
Copy link
Member Author

The backport has produced an important regression:

Exception in thread "main" java.lang.ExceptionInInitializerError
	at org.jooq.test.h2.generatedclasses.public_.Tables.<clinit>(Tables.java:224)
	at org.jooq.testscripts.JDBC.main(JDBC.java:39)
Caused by: java.lang.NullPointerException: Cannot invoke "java.lang.CharSequence.length()" because "this.text" is null
	at java.base/java.util.regex.Matcher.getTextLength(Matcher.java:1769)
	at java.base/java.util.regex.Matcher.reset(Matcher.java:415)
	at java.base/java.util.regex.Matcher.<init>(Matcher.java:252)
	at java.base/java.util.regex.Pattern.matcher(Pattern.java:1134)
	at org.jooq.impl.DefaultDataType.<init>(DefaultDataType.java:349)
	at org.jooq.impl.AbstractDataType.asEnumDataType(AbstractDataType.java:672)
	at org.jooq.test.h2.generatedclasses.public_.tables.TBook.<init>(TBook.java:103)
	at org.jooq.test.h2.generatedclasses.public_.tables.TBook.<init>(TBook.java:116)
	at org.jooq.test.h2.generatedclasses.public_.tables.TBook.<init>(TBook.java:141)
	at org.jooq.test.h2.generatedclasses.public_.tables.TBook.<clinit>(TBook.java:40)
	... 2 more

We can't publish 3.17.7 with this regression.

@lukaseder
Copy link
Member Author

The NPE can be prevented by backporting a part of #13934

@lukaseder
Copy link
Member Author

Definitely related. I'll backport #13934

@lukaseder lukaseder mentioned this issue Dec 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Code Generation C: DB: H2 E: All Editions P: Medium R: Fixed T: Enhancement
Projects
None yet
Milestone
Version 3.17.7
Development

No branches or pull requests
1 participant
@lukaseder