Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various UDT related issues in KotlinGenerator #15507

Closed
2 tasks done
lukaseder opened this issue Aug 25, 2023 · 2 comments
Closed
2 tasks done

Fix various UDT related issues in KotlinGenerator #15507

lukaseder opened this issue Aug 25, 2023 · 2 comments
Labels
C: Code Generation C: Integration: Kotlin E: All Editions P: Medium R: Fixed T: Defect
Projects
3.19 Other improvements
Milestone
Version 3.19.0

Comments

@lukaseder
Copy link
Member

The KotlinGenerator has various UDT related issues, where imports aren't generated correctly. So far, this didn't seem to have any effect, because the logic wasn't covered by most code generation paths, but with UDT paths, they have surfaced:

The issues include:

  • GeneratorStrategy::getFullJavaIdentifier not producing the correct reference
  • references not being ported correctly (lack of attrRefSegments() method, similar to domainRefSegments() in JavaGenerator)
@lukaseder lukaseder added this to the Version 3.19.0 milestone Aug 25, 2023
@lukaseder lukaseder added this to To do in 3.19 Other improvements via automation Aug 25, 2023
@lukaseder
Copy link
Member Author

Given the issues haven't surfaced before, and given the complexity of #228, I won't backport this fix. The fix will be implemented with #228.

3.19 Other improvements automation moved this from To do to Done Aug 25, 2023
@lukaseder lukaseder reopened this Aug 25, 2023
3.19 Other improvements automation moved this from Done to In progress Aug 25, 2023
@lukaseder
Copy link
Member Author

This is harder than I thought. Will look into this again next week.

3.19 Other improvements automation moved this from In progress to Done Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Code Generation C: Integration: Kotlin E: All Editions P: Medium R: Fixed T: Defect
Projects
No open projects
3.19 Other improvements
Done
Milestone
Version 3.19.0
Development

No branches or pull requests
1 participant
@lukaseder