Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.jooq.tools.Convert should delegate to org.jooq.impl.Convert, instead of duplicating implementations - Merge [#16044] #16045

Closed
lukaseder opened this issue Jan 10, 2024 · 4 comments

Comments

@lukaseder
Copy link
Member

No description provided.

@alf
Copy link

alf commented Apr 6, 2024

This change seems to have fixed a bug in the handling of LocalDate from within a multiset (i.e. json).

We have a green test that turns red when bumping jOOQ from 3.19.1 to 3.19.2 (and further). This has held us from upgrading since we didn't have time to look into the problem before now. I've now simplified the failing test to the following:

var result = ctx.select(
                multiset(select(
                        val("2013-07-01T00:00:00", LocalDate.class)
                        )
                )
        ).fetchOne();

        assertNull(result.component1().get(0).component1());

Obviously the test is incorrect, but it slipped past our QA.

@lukaseder
Copy link
Member Author

@alf I'd say, this was an expected improvement, given that this issue of yours has been fixed in 3.19.2?

@alf
Copy link

alf commented Apr 9, 2024 via email

@lukaseder
Copy link
Member Author

No worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants