Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetchOne(RecordMapper) shortcut method to ResultQuery #3810

Merged
merged 1 commit into from Nov 26, 2014
Merged

Add fetchOne(RecordMapper) shortcut method to ResultQuery #3810

merged 1 commit into from Nov 26, 2014

Conversation

lpireyn
Copy link
Contributor

@lpireyn lpireyn commented Nov 26, 2014

No description provided.

@lukaseder
Copy link
Member

Thanks for the suggestion.

As we're dual-licensing jOOQ, we need to ensure that rights to non-trivial contributions are properly transferred before I can look into merging your pull request:
http://www.jooq.org/legal/contributions

If you're OK with such an agreement, please e-sign the above document. If not, that's perfectly fine. We can simply implement suggestions as well...

@lpireyn
Copy link
Contributor Author

lpireyn commented Nov 26, 2014

If I sign the agreement, do you guarantee that my personal informations
(e.g. address) will never be used or transmitted?

On Wed, Nov 26, 2014 at 10:56 AM, Lukas Eder notifications@github.com
wrote:

Thanks for the suggestion.

As we're dual-licensing jOOQ, we need to ensure that rights to non-trivial
contributions are properly transferred before I can look into merging your
pull request:
http://www.jooq.org/legal/contributions

If you're OK with such an agreement, please e-sign the above document. If
not, that's perfectly fine. We can simply implement suggestions as well...


Reply to this email directly or view it on GitHub
#3810 (comment).

Laurent Pireyn
Pi Solutions

@lukaseder
Copy link
Member

Yes, we guarantee that we will not use or transmit your personal information. We only need this information to identify you or the legal entity you represent in the context of this agreement.

@lpireyn
Copy link
Contributor Author

lpireyn commented Nov 26, 2014

Thanks. I signed the agreement.

On Wed, Nov 26, 2014 at 11:48 AM, Lukas Eder notifications@github.com
wrote:

Yes, we guarantee that we will not use or transmit your personal
information. We only need this information to identify you or the legal
entity you represent in the context of this agreement.


Reply to this email directly or view it on GitHub
#3810 (comment).

Laurent Pireyn
Pi Solutions

@lukaseder
Copy link
Member

Thank you very much, and thanks again for the useful contribution

lukaseder added a commit that referenced this pull request Nov 26, 2014
[#3810] Add fetchOne(RecordMapper) shortcut method to ResultQuery
@lukaseder lukaseder merged commit 650e98a into jOOQ:master Nov 26, 2014
@lpireyn
Copy link
Contributor Author

lpireyn commented Nov 26, 2014

You're welcome. Thanks for jOOQ which is an amazing lib!

Are you interested in pull requests that would be optimizations across all
classes? E.g. Replace single-character strings with characters in
concatenations. Let me know ;-)

On Wed, Nov 26, 2014 at 12:06 PM, Lukas Eder notifications@github.com
wrote:

Thank you very much, and thanks again for the useful contribution


Reply to this email directly or view it on GitHub
#3810 (comment).

Laurent Pireyn
Pi Solutions

@lukaseder
Copy link
Member

Are you interested in pull requests that would be optimizations across all
classes?

Of course!

E.g. Replace single-character strings with characters in
concatenations.

Well, that would be a bit of work. Is the gain really significant?

@lpireyn
Copy link
Contributor Author

lpireyn commented Nov 26, 2014

I work with IntelliJ, and it can automatically fix these issues in one
click.

These are obviously tiny optimizations, and the gain is probably
unnoticeable. That's why I'm asking you if you think it's worth a commit.

On Wed, Nov 26, 2014 at 12:42 PM, Lukas Eder notifications@github.com
wrote:

Are you interested in pull requests that would be optimizations across all
classes?

Of course!

E.g. Replace single-character strings with characters in
concatenations.

Well, that would be a bit of work. Is the gain really significant?


Reply to this email directly or view it on GitHub
#3810 (comment).

Laurent Pireyn
Pi Solutions

@lukaseder
Copy link
Member

The problem with pull requests to the jOOQ Open Source edition is that we have to merge them back to the "master" repository - the commercial jOOQ edition. I have an IntelliJ license as well, so if you can give me a pointer, I'd prefer to do this particular change myself...

I think it's a thing worth pursuing as jOOQ is used at a very low level of client applications and thus might have a lot of impact - even if its just a sub-percent optimisation.

@lukaseder
Copy link
Member

Btw: Let's continue discussing this issue over here: #3816 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants