Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete @Support annotations on UpdateQuery.addValues(Row[N], Select) #9311

Closed
lukaseder opened this issue Oct 1, 2019 · 0 comments
Closed

Comments

@lukaseder
Copy link
Member

This API:

    @Support({ DB2, H2, HANA, HSQLDB, INGRES, ORACLE })
    <T1, T2> void addValues(Row2<T1, T2> row, Select<? extends Record2<T1, T2>> select);

Is being called from UpdateSetFirstStep, internally, which has this API:

    @Support({ AURORA_POSTGRES, DB2, H2, HANA, HSQLDB, INGRES, ORACLE, POSTGRES_9_5 })            
    <T1, T2> UpdateFromStep<R> set(Row2<T1, T2> row, Select<? extends Record2<T1, T2>> select);

The support annotations don't match. They're missing AURORA_POSTGRES and POSTGRES_9_5. Curiously, our recent integration tests did not catch this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant