Fixed #246 Check maven-surefire-plugin configuration/definition #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed provider dependencies, cause this will be done by maven-surefire/maven-failsafe automatically. Added maven-enforcer rule to make sure maven-surefire/ maven-failsafe/maven-surefire-report-plugin will have the same version.
|
Looks fine. Thx. |
|
Applied the patch manually (I hate merge commits). |
|
There was a situation when we needed to specify the provider - as far as I remember the TestNG plugin contained classes with both JUnit and TestNG annotations. Just had a look the plugin module, the situation is no longer this way, thus it should be ok to simplify surefire configuration. |
|
It would be good to document the relationals behind this directly in the source or what ever. Every decision has a good reason but after sometime no ones remembers the reason. |
|
See #249 for problems causes be this fix. Relates to #252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed provider dependencies, cause this will be done
by maven-surefire/maven-failsafe automatically.
Added maven-enforcer rule to make sure maven-surefire/
maven-failsafe/maven-surefire-report-plugin will have
the same version.