Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

Please upgrade to tendermint 0.15 #34

Closed
juntao opened this issue Jan 11, 2018 · 4 comments
Closed

Please upgrade to tendermint 0.15 #34

juntao opened this issue Jan 11, 2018 · 4 comments

Comments

@juntao
Copy link

juntao commented Jan 11, 2018

Tendermint 0.15 introduced a number of breaking changes to the ABCI protocol. I believe the following pull request addresses those changes. Please review. Thank you.

#33

@srmo
Copy link
Member

srmo commented Jan 13, 2018

We are working on this. The PR already contains some discussion. We need to clarify some things related to the gogoproto types in tendermint's reference proto file. It's not trivial to port them (at least for us). The suggested PR removed those gogoproto types but we need to make sure that this change doesn't produce any side-effects in non-trivial use cases. Then again, what is a trivial use-case?

Stay tuned. We are at least as interested as you to bring jABCI to tm 15+

@juntao
Copy link
Author

juntao commented Jan 14, 2018 via email

@srmo
Copy link
Member

srmo commented Jan 14, 2018

Not really, idea is that we get an answer from tendermint on tendermint/abci#179 during the week so we know what to do.

@wolfposd
Copy link
Contributor

done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants