Reduce Paints and Cache DOM Queries #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Jake,
I'm loving this project! So proud of you for quitting smoking and I think this type of visualization as a motivator is a great idea.
I'm submitting this pull request as part of #Hacktoberfest. I noticed that there were paints happening on all progresses each frame, even if the data hadn't changed. I reconfigured a few things to reduce that:
constoutside of RAFDate.now()overnew Date().getTime(), (slightly more performant)You can see the before and after of the paint rectangles here: https://imgur.com/a/CAgp00c
No pressure to merge, of course. Best of luck to you on your journey!