Feature: Make support of package types #82
Conversation
package.json
Outdated
| @@ -38,6 +41,7 @@ | |||
| "eslint-config-google": "0.14.0", | |||
| "jest": "29.3.1", | |||
| "mocha": "10.1.0", | |||
| "npm-run-all": "^4.1.5", | |||
There was a problem hiding this comment.
I think adding dependency just not to use basic && command feels overkill.
| @@ -14,7 +14,7 @@ import { IConnection, PlainConnection, SecureConnection } from "./connection"; | |||
| // Inherit from `winston-transport` so you can take advantage | |||
| // of the base functionality and `.exceptions.handle()`. | |||
| // | |||
| module.exports = class LogstashTransport extends Transport { | |||
There was a problem hiding this comment.
How does this affect backward compatibility? I have spent quite a lot of time keeping everything backwards compatible and it's important to understand if there are complications due to this change.
There was a problem hiding this comment.
It supposed to be no changes compared with the previous version, changing to a new export style due to the tsc compiler not recognizing the module.exports inside the file and does not export anything for types.
|
The babel does not support the |
|
Hello @jaakkos, do I need to do something for you to help the PR be easily merged? |
Fix the package that does not have any declaration file exported when using typescript.