Stringify Sidekiq.default_worker_options's keys, fix sidekiq#2124

jaanek · Jan 9, 2015 · 33b9999 · 33b9999
1 parent 51b846b
commit 33b9999
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/Changes.md b/Changes.md
@@ -1,5 +1,6 @@
 HEAD
 -----------
+- Stringify Sidekiq.default_worker_options's keys [#]
 - Add random integer to process identity [#2113, michaeldiscala]
 - Log Sidekiq Pro's Batch ID if available [#2076]
 - Refactor Processor Redis usage to avoid redis/redis-rb#490 [#]

diff --git a/lib/sidekiq.rb b/lib/sidekiq.rb
@@ -97,7 +97,7 @@ def self.server_middleware
   end
 
   def self.default_worker_options=(hash)
-    @default_worker_options = default_worker_options.merge(hash)
+    @default_worker_options = default_worker_options.merge(hash).stringify_keys!
   end
 
   def self.default_worker_options

diff --git a/test/test_sidekiq.rb b/test/test_sidekiq.rb
@@ -54,4 +54,16 @@ class TestSidekiq < Sidekiq::Test
       assert_equal 2, Sidekiq.options[:lifecycle_events][:startup].first.call
     end
   end
+
+  describe 'default_worker_options' do
+    before do
+      @old_options = Sidekiq.default_worker_options
+    end
+    after  { Sidekiq.default_worker_options = @old_options }
+
+    it 'stringify keys' do
+      Sidekiq.default_worker_options = { queue: 'cat'}
+      assert_equal 'cat', Sidekiq.default_worker_options['queue']
+    end
+  end
 end