修正逻辑错误 #43
Merged
修正逻辑错误 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e方法之后会产生让人抓狂的bug。 bug 具体内容： 当我实现完整的validate方法之后， 若按照原来的逻辑， 会执行else 的语句， 但是else 中直接break, 所以并未执行for的第三句话。 所以导致this.position一直未自增
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
此处逻辑应该为 先验证是否stime < time 再验证此条弹幕是否能通过filter的验证， 否则当补全validate方法之后会产生bug。
bug 具体内容： 当我实现完整的validate方法之后， 若按照原来的逻辑， 会执行else 的语句， 但是else 中直接break, 所以并未执行for的第三句话。 所以导致this.position一直未自增.