Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge the new version of CommentCoreLibrary with enhanced APIs #63

Merged
merged 59 commits into from
Apr 25, 2017
Merged

Merge the new version of CommentCoreLibrary with enhanced APIs #63

merged 59 commits into from
Apr 25, 2017

Conversation

jabbany
Copy link
Owner

@jabbany jabbany commented Oct 19, 2016 •
edited

This is the branch for v0.11.0 with a new CommentProvider interface system for loading comments. This version provides:

  • Better Acfun comment compatibility
  • Better modularized system for parsers
  • Revised CommentFilter
  • Multiple cleanups of unused resources
  • Documentation fixes
  • Output location now conforms to npm conventions using dist/
  • Better Code Danamku support on KagerouEngine

Some roadblocks currently:

  • Rebasing the CSS only version on this branch so we can use the much faster CSS rendering in the future. (Done)
  • Needs more tests to bring coverage up!

jabbany and others added 30 commits November 30, 2014 10:34
@jabbany
Working CSS only render
4825af1
@jabbany
Improved efficiency greatly. Uses full HW acceleration if available f…
c4d57c3 
…or CSS.

Resolves #38, Resolves #21
@jabbany
Merge changes from master
041766f
@WhiteBlue
add ScrollComment 'CSS animation' mode
29e1e59
@jabbany
Merge branch 'WhiteBlue-dev-cssonly' into dev-cssonly
8bfe620
@jabbany
Merge cleanup
e3b167f
@jabbany
Update from master
0b230b6
@jabbany
Merge branch 'master' into dev-cssonly
d5d2397 
Conflicts:
	build/CommentCoreLibrary.min.js
@jabbany
Bump version
66b1240
@jabbany
Merge branch 'master' into dev-cssonly
25560c6 
Conflicts:
	build/CommentCoreLibrary.min.js
@jabbany
Bump version after bugfix
1ec6aca
@jabbany
Cleanup and add stop polyfill.
eb8bf0d
@jabbany
Merge branch 'master' into dev-cssonly
de119d3
@jabbany
New loading method
44e6ece 
Pending test cases
Pending documentation
@jabbany
Added some more tests to cover new comment loading system
17a7b3d
@jabbany
Restructuring project
25cb15e 
- Change compile location to dist/ to better align with other npm frontend projects
- Make parsers better again
- Fix some issues with documentation
- Bump versions in preparation for breaking API changes
@jabbany
Fix some errors and indentation
512452c
@jabbany
More enhancements
903d4a9 
- Removed files not being used (will migrate to alternate project) or not working (e.g. things in src/extend)
- Renamed demo/intro to demo/tutorial to reflect future renaming of Intro.md to Tutorial.md
- Fixed demo to use files in dist/ following change of compile target directory
- Figured out how to parse AcFun advanced mode comments.
- Separated the Comment object's .align into .align (align mode) and .axis (axis direction)
- Enhancements to CommonDanmakuFormat and AcfunFormat
@jabbany
Fix tests
ecd3875
@jabbany
Working CSS only render
56fcc9c
@jabbany
Improved efficiency greatly. Uses full HW acceleration if available f…
8ed9a18 
…or CSS.

Resolves #38, Resolves #21
@WhiteBlue @jabbany
add ScrollComment 'CSS animation' mode
70b253c
@jabbany
Merge cleanup
23f72cb
@jabbany
Bump version
89b55cf
@jabbany
Bump version after bugfix
57ce088
@jabbany
Cleanup and add stop polyfill.
65ba033
@jabbany
Update URLs to not use vanity domain
7699890
@jabbany
Update dependencies and use grunt-ts instead of grunt-typescript for …
4b3d37a 
…compiling typescript.
@jabbany
Merge branch 'dev-cssonly' of github.com:jabbany/CommentCoreLibrary i…
d61d9f5 
…nto dev-cssonly

Conflicts:
	package.json
@jabbany
Merge remote-tracking branch 'origin/master' into dev-cssonly
db6bd13 
Conflicts:
	build/CommentCoreLibrary.min.js
@coveralls
Copy link

Coverage Status

Coverage increased (+1.05%) to 73.84% when pulling 2469643 on dev-new-loader into 684d54c on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.3%) to 76.134% when pulling 0319e51 on dev-new-loader into 684d54c on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.3%) to 76.134% when pulling da225a3 on dev-new-loader into 684d54c on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.3%) to 76.134% when pulling fefb62b on dev-new-loader into 684d54c on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.3%) to 76.114% when pulling 2dc8a85 on dev-new-loader into 684d54c on master.

@jabbany
Merge branch 'dev-cssonly' into dev-new-loader
e3ab70b 
Fix various issues:
- Bugs in scripting system
- Unified timer for MotionManager
- CSS comments default

Need to fix before merge to master:
- Reverse scroll does not work!
@jabbany
Fixed error with reverse danmaku in CSS mode
9974831
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 73.676% when pulling 9974831 on dev-new-loader into 684d54c on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 73.676% when pulling 2284bd6 on dev-new-loader into 684d54c on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 73.676% when pulling 57fdb60 on dev-new-loader into 684d54c on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 73.676% when pulling 3a95807 on dev-new-loader into 684d54c on master.

@jabbany
Many changes:
28e8f6a 
- Implemented bezier animation for Tween
- Fixed Tween base case
- Modernize dependencies
- Fix bug with Bilibiliparser to accept false and 'false' for border
- More documentation in more languages
- Fixed syntax errors in comment festival XML file, preparing to implement Bitmap library
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 73.564% when pulling 28e8f6a on dev-new-loader into 684d54c on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 73.564% when pulling c17c05c on dev-new-loader into 684d54c on master.

@jabbany
Multiple updates:
d3e62de 
- Better documentation
- Fixed some bugs with AS3 defaults including perspective calculation
- Implemented some of Bitmap support
- Fixed lots of indentation
- Removed unused files
@jabbany
Copy link
Owner Author

jabbany commented Apr 25, 2017

This is almost good...

@jabbany
Modified scripting engine framework:
71afc6f 
- Beginnings of Bitmap support
- Fixed some bugs with the (soon to be re-written in TypeScript Host.js)
- Removed unused 3D tests
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 73.564% when pulling 71afc6f on dev-new-loader into 684d54c on master.

@jabbany jabbany merged commit 294a6f6 into master Apr 25, 2017
@jabbany jabbany deleted the dev-new-loader branch May 9, 2017 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jabbany jabbany

Labels
enhancement
Projects
None yet
Milestone
Improve APIs and Documentation
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jabbany @coveralls @WhiteBlue