Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing device category field #500

Open
fragsalat opened this issue Jun 25, 2024 · 0 comments
Open

Add missing device category field #500

fragsalat opened this issue Jun 25, 2024 · 0 comments

Comments

@fragsalat
Copy link

Hey there,

could you maybe add the category field for NACamDoorTag entities? Those tell me whether it is a door or a window and I can create corresponding entities in homeassistant for that. The data is passed through /homesdata endpoint. Example payload below

{
  id:"xx:xx:xx:yy:yy:yy:"
  type:"NACamDoorTag"
  name:"Terassentür"
  setup_date:1639423483
  bridge:"xx:xx:xx:yy:yy:yy"
  category:"door"
}
{
  id:"xx:xx:xx:yy:yy:yy"
  type:"NACamDoorTag"
  name:"Fenster Wohnzimmer"
  setup_date:1639424076
  bridge:"xx:xx:xx:yy:yy:yy"
  category:"window"
}

Currently a device_category exists but this is derived from the type and in case of NACamDoorTag it is OPENING. Do be backward compatible you could simply pass the field category from the raw data or just store the raw data and let people access it.

Thanks for your support and the good library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant