Add preferred position functionnality to shutter #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @PoppyPop - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
tests/test_shutter.py
Outdated
| @@ -84,6 +84,12 @@ def gen_json_data(position): | |||
| endpoint="api/setstate", | |||
| ) | |||
|
|
|||
| assert await module.async_preferred_position() | |||
There was a problem hiding this comment.
suggestion (testing): Test for edge case of target_position < -2
Consider adding a test case to ensure that when target_position is set to a value less than -2, it defaults to -1. This will help verify the backward compatibility and the new functionality.
There was a problem hiding this comment.
the test assert await module.async_set_target_position(-10) already cover this
jabesq
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In the control APP, i have access to a "preferred position" for my shutter.
After some test and digging in the API, i noticed that there is an undocumented value of -2 for this.
Here is a small PR that add the functionnality.
i tested it in my setup and it's working well.
i modified the code, to be backward compatible (low value return -1 as before for example)
Feel free to ask if you need more screenshot or proof of the functionnality
Have a nice day !
FYI, it's the round icon at the right
