Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1841 Select applications for character checks by application status #1935

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

#1841 Select applications for character checks by application status #1935

wants to merge 6 commits into from

Conversation

tomlovesgithub
Copy link
Contributor

What's included?

Adds dropdown selections for stage and status.
Using availableStatuses so should slot in and be improved by this pr.

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

  • Navigate to an exercise with character checks
  • Check the available stages and status work to filter the table contents
  • find any flaws or issues within this

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

image

PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@tomlovesgithub tomlovesgithub requested review from a team as code owners March 16, 2023 18:20
@tomlovesgithub tomlovesgithub temporarily deployed to develop March 17, 2023 16:56 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Mar 17, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 6f951fc):

https://jac-admin-develop--pr1935-1841-char-check-sele-36533pha.web.app

(expires Sat, 29 Apr 2023 09:42:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@tomlovesgithub tomlovesgithub temporarily deployed to develop March 23, 2023 16:24 — with GitHub Actions Inactive
HalcyonJAC
HalcyonJAC requested changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@HalcyonJAC HalcyonJAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I select the status Invited To selection, it shows blank and the data in the table seems not correct.

Screen.Recording.2023-03-24.at.09.18.12.mov

@warrensearle warrensearle changed the title 1841/char check select stage #1841 Select applications for character checks by application status Mar 30, 2023
@warrensearle warrensearle temporarily deployed to develop March 30, 2023 09:39 — with GitHub Actions Inactive
warrensearle
warrensearle approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I think this needs #1861 to be merged first though, is that right @tomlovesgithub?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalcyonJAC HalcyonJAC HalcyonJAC requested changes

@warrensearle warrensearle warrensearle approved these changes

@andrew-isaac andrew-isaac andrew-isaac approved these changes

@drieJAC drieJAC drieJAC approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tomlovesgithub @warrensearle @HalcyonJAC @andrew-isaac @drieJAC