Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2154 Configure working preferences questions #2207

Merged
merged 35 commits into from
Jul 1, 2024
Merged

Conversation

warrensearle
Copy link
Member

@warrensearle warrensearle commented Oct 25, 2023

What's included?

Additional configuration options for working preferences questions, as follows:

  • Enable multiple location questions. (e.g. this will enable preferred and maybe selections)
  • Enable multiple jurisdiction questions. (e.g. this will enable preferred and maybe selections)
  • Define how many answers candidates should select
  • Enable linked questions (e.g. if a particular answer is chosen then the user is asked a follow-on question)
  • Enable grouping of answers (two levels)
  • Allow re-use of jurisdictions from vacancy information (for jurisdiction questions)

Closes #2154

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

We decided to continue to support current functionality for existing exercises and have new exercises benefit from the new functionality.

There are therefore two areas to test:

1. There should not be any breaking changes for existing exercises

Either pick an existing exercise that is configured with the original working preferences OR use the main admin-develop url to create a new exercise and configure working preferences for it.

View the chosen/created exercise on the Preview URL and check that working preferences works as expected (as it does on admin-develop). For example you could have admin-develop and preview url running in separate windows and compare the functionality side by side.

You should be able to:

  • Configure and edit one location preference
  • Configure and edit one jurisdiction preference
  • Configure and edit multiple additional preferences
  • View a candidate's chosen preferences on their application
  • Edit a candidate's chosen preferences on their application (in 'edit mode')

Note: you may like to create an application via apply-develop so you can test viewing and editing applications.

Please highlight any breaking changes.

2. New exercises should benefit from the new functionality and the new functionality satisfies user requirements

Using the Preview URL please create a new exercise and check that the new working preferences functionality is available.

In particular check that the following functionality works as expected and also that the terminology and instructions provided are sufficiently clear.

  1. Check that you can add multiple location questions
  2. Check that you can add multiple jurisdiction questions
  3. Check that you can define how many answers candidates should select (for multiple and ranked choice questions)
  4. Check that you can create a linked / follow-on question (where if a user selects one answer they are asked a follow-on question)
  5. Check that you can group answers
  6. Check that, for jurisdiction questions, you can choose to use the exercise jurisdictions list instead of re-entering the data

Note: when you have tested the above please test this PR on Apply so that you have an application with the latest preferences data.

Then back in Admin continue to test the following in Applications:

  1. Check that all working preferences answers are displayed correctly on the candidate's application
  2. Check that all working preferences can be edited when the application is in 'edit mode'

Risk - how likely is this to impact other areas?

🟠 Medium risk - this does change code that is shared with other areas


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@warrensearle warrensearle requested review from a team as code owners October 25, 2023 08:06
@warrensearle warrensearle temporarily deployed to develop October 25, 2023 08:08 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 25, 2023

Visit the preview URL for this PR (updated for commit eb50696):

https://jac-admin-develop--pr2207-feature-2154-d8s2h7zf.web.app

(expires Wed, 31 Jul 2024 14:13:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@warrensearle warrensearle marked this pull request as draft October 25, 2023 08:19
@warrensearle warrensearle changed the title #2154 Configure working preferences questions [WIP] #2154 Configure working preferences questions Oct 25, 2023
@warrensearle warrensearle temporarily deployed to develop October 25, 2023 08:21 — with GitHub Actions Inactive
@warrensearle warrensearle changed the title [WIP] #2154 Configure working preferences questions #2154 Configure working preferences questions Jan 29, 2024
@nickaddy
Copy link
Contributor

@warrensearle As keen as I am to see the back of this, I cannot see half of this functionality on the preview url - I was testing on this exercise. I couldn't see any options to:

  • Define how many answers candidates should select
  • Enable linked questions (e.g. if a particular answer is chosen then the user is asked a follow-on question)
  • Enable grouping of answers (two levels)
  • Allow re-use of jurisdictions from vacancy information (for jurisdiction questions)

@nickaddy
Copy link
Contributor

@warrensearle there seems to be an issue with saving after editing a candidate's loc or juri preference; the button turns yellow but does not disappear and when you click Done, changed answers have not been saved.

image.png

@nickaddy
Copy link
Contributor

@warrensearle Interestingly, I just submitted a new application and I did not experience the issue above - I was able to edit and save all responses.

@warrensearle
Copy link
Member Author

I propose closing this ticket and moving any future changes or bugs to new tickets.

Note that I have re-opened the following two tickets as the described functionality needs to be updated with changes/simplifications made in this pull request:

#2318

#2319

@warrensearle
Copy link
Member Author

@nickaddy please can you approve this PR, particularly if you agree with the above suggestion

@warrensearle warrensearle merged commit 8c2df30 into main Jul 1, 2024
6 checks passed
@warrensearle warrensearle deleted the feature/2154 branch July 1, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure working preferences questions
7 participants