Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2424 Support Reset of Character Report #2459

Merged
merged 8 commits into from
Jul 1, 2024

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Jun 25, 2024

What's included?

Closes #2424

Related PR: digital-platform: Feature/admin 2424 Support Reset of Character Report #1123

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Example exercise: Ryan test 1 (Character issues)

Note: The "Reset" button is only visible for Digital Super User.

Steps:

  1. Go to the Character Issues report and hit the Reset button.
  2. Check if the data is repopulated from applications.

Risk - how likely is this to impact other areas?

🟢 No risk - this is a self-contained piece of work

Additional context

Demo:

2424.Support.Reset.of.Character.Report.mp4

Related permissions

New permission: canResetCharacterIssuesReport


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

Copy link

github-actions bot commented Jun 25, 2024

Visit the preview URL for this PR (updated for commit 587ad84):

https://jac-admin-develop--pr2459-feature-2424-support-mc5hdyo3.web.app

(expires Sat, 27 Jul 2024 09:41:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4e92cf51659207b0ae3509dc5c40edde50edfec0

@nickaddy
Copy link
Contributor

@HalcyonJAC I'm finding that I'm able to reset the report by pressing the refresh button, i.e. it's not locked?

@HalcyonJAC
Copy link
Contributor Author

@HalcyonJAC I'm finding that I'm able to reset the report by pressing the refresh button, i.e. it's not locked?

@nickaddy Thank you for spotting that. I have sorted it. Could you test it again, please?

Copy link
Contributor

@nickaddy nickaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HalcyonJAC Looks good to me 👍

@HalcyonJAC HalcyonJAC merged commit c73c12e into main Jul 1, 2024
6 checks passed
@HalcyonJAC HalcyonJAC deleted the feature/2424-support-reset-of-character-report branch July 1, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support reset of character report
4 participants