Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file upload restrictions #110

Merged
merged 3 commits into from Jul 9, 2021
Merged

file upload restrictions #110

merged 3 commits into from Jul 9, 2021

Conversation

HalcyonJAC
Copy link
Contributor

@HalcyonJAC HalcyonJAC commented Apr 21, 2021

What's included?

For details please see parent ticket in ZenHub. https://app.zenhub.com/workspaces/platform-development-5ea838cd2aec471eb6d14139/issues/jac-uk/digital-platform/327

This project had its own implementation of the FileUpload component instead of the one that is part of the JAC Kit. However, there is only one file in this project that uses a FileUpload component and the functionality required is the same as the one in the JAC Kit anyway I removed it in favour of the JAC Kit component. The idea here is 2-fold:

  • Get the new changes to the file upload restrictions, which have been implemented in the JAC Kit FileUpload component.
  • Remove the (now redundant) FileUpload component from the assessments project as it no longer needs its own implementation of it as such.

Who should test?

✅ Product owner
✅ Developers
✅ UTG

How to test?

Describe the steps required to test & verify this change

Risk - how likely is this to impact other areas?

🟠 Medium risk - this does change code that is shared with other areas


PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING

@HalcyonJAC HalcyonJAC self-assigned this Apr 21, 2021
@HalcyonJAC HalcyonJAC marked this pull request as ready for review April 22, 2021 13:39
@warrensearle warrensearle marked this pull request as draft May 14, 2021 10:50
@HalcyonJAC HalcyonJAC temporarily deployed to develop June 10, 2021 09:44 Inactive
@github-actions
Copy link

github-actions bot commented Jun 10, 2021

Visit the preview URL for this PR (updated for commit 72efd28):

https://jac-assessments-develop--pr110-feature-file-upload-91o55lsh.web.app

(expires Sat, 31 Jul 2021 10:58:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@HalcyonJAC HalcyonJAC marked this pull request as ready for review June 10, 2021 09:51
@HalcyonJAC HalcyonJAC requested review from a team as code owners June 10, 2021 09:51
@HalcyonJAC HalcyonJAC requested review from JeremykJAC and joy-ade and removed request for a team June 10, 2021 09:51
@HalcyonJAC HalcyonJAC temporarily deployed to develop June 10, 2021 09:52 Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop June 10, 2021 09:56 Inactive
@HalcyonJAC HalcyonJAC temporarily deployed to develop July 1, 2021 10:55 Inactive
@KateMJAC KateMJAC added this to the 21JUL milestone Jul 6, 2021
@KateMJAC KateMJAC removed the request for review from joy-ade July 9, 2021 10:46
@KateMJAC KateMJAC self-requested a review July 9, 2021 10:46
@KateMJAC KateMJAC merged commit 218e2ef into main Jul 9, 2021
@KateMJAC KateMJAC deleted the feature/file-upload-restrictions branch July 9, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants