Update workflows to target staging and production #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warrensearle
requested review from
lloback,
JeremykJAC,
tomlovesgithub,
joy-ade and
mbrookeswebdev
and removed request for
a team,
lloback,
JeremykJAC and
joy-ade
|
Visit the preview URL for this PR (updated for commit a2c6755): https://jac-assessments-develop--pr118-feature-enable-produ-ayqi7vqt.web.app (expires Thu, 17 Jun 2021 16:41:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
tomlovesgithub
approved these changes
May 19, 2021
mbrookeswebdev
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included?
Here we are amending our workflows to target
stagingandproduction. Previously these targeteddevelopfor testing purposes.Who should test?
✅ Developers
How to test?
Review code changes and check that staging and production are targeted correctly.
Re-run the test script from #115 in order to verify that the changes work as expected - you'll need to merge this PR in order to go through the full pipeline checks.
Risk - how likely is this to impact other areas?
🔴 High risk - this deploys to the live production environment so should be tested thoroughly
PREVIEW:DEVELOP
can be OFF, DEVELOP or STAGING