Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change backlink to go back to a specific page #47

Merged
merged 6 commits into from
Jul 30, 2020

Conversation

crablab
Copy link
Contributor

@crablab crablab commented Jul 23, 2020

Simple change to the backlink component.

I don't know if this is too "hacky'. It's the easiest way to make this change, it may be that we want something nicer (a new component, for example).

Copy link
Member

@warrensearle warrensearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this instance I'd suggest not using the Back component and simply having something along the lines of the following in the view:
<a class="govuk-back-link" @click="$router.push('/assessments')">Assessments</a>

@crablab
Copy link
Contributor Author

crablab commented Jul 29, 2020

Cool 👍 I was on the fence about that one; easy to change! 😄

@crablab crablab requested review from warrensearle and YaaL and removed request for warrensearle July 30, 2020 08:16
Copy link
Contributor

@YaaL YaaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@YaaL YaaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@YaaL YaaL merged commit b13c4e5 into develop Jul 30, 2020
@YaaL YaaL deleted the feature/30-back-button-incorrect-dest branch July 30, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants