#51 - Show errors to asssesors on late IAs

[crablab]

This adds a number of things:

• the Warning component from admin
• the date helpers from admin
• On /assessments an "overdue" call out when the assessment is past the deadline and incomplete
• On /assessments a new disabled button for when the assessment is past the hard limit (and thus expired)
• On /edit an "overdue" call out the Warning component when the assessment is past the deadline and incomplete
• On /edit the Warning component when the assessment is past the hard limit and expired, with contact details for the teams

This currently won't do anything, as assessment.hardLimit isn't being copied across in the function. We may want to tweak some stuff when we see how this is all working together.

Overdue but within hard limit:

Overdue and past hard limit:

[warrensearle]

Hey @crablab some of these changes aren't in the ticket #51 you're working on. Is there another ticket requesting the additional changes? Some of them reverse changes that were applied in the past - e.g. in #9 we removed the 'overdue' labels.

[crablab]

@warrensearle I think that's a bit of a strict interpretation to be honest. I thought these would be useful added value changes, in line with the overall aim of the ticket: to make it clear when an IA is running late and has expired.

[YaaL]

@warrensearle with the soft and hard return date it makes sense to have the overdue label.
TBH I'm not sure why it was removed?

[warrensearle]

@ClaireTroughtonJAC or @Rebecca-mcknight1991 please can you confirm the reasoning for removing the Overdue label. Suggest we move this discussion to slack / stand-up.

[ClaireTroughtonJAC]

@warrensearle The reason I asked for it to be removed is I don't think Overdue is not the best label for an assessor to see. I think the due date is sufficient. I think we inform Assessors of this in other ways of outstanding assessor.

[crablab]

@ClaireTroughtonJAC Is it best to not have the 'overdue' message at all, or is there better copy we could use? Just conscious that at the moment there is no indication on the IA pages that an assessment is late, and this could be a poor user experience if the assessor didn't realise and then exceeded the hard limit.

[ClaireTroughtonJAC]

Will review warning component later when on staging.

[crablab]

Discussed with Claire this morning and we're making the following changes:

• Remove OVERDUE labels
• Use warning component on /edit if an IA is running late

Potentially another ticket to use the warning component on /assessments.

[crablab]

@warrensearle would it be possible to get a review on this please?

[warrensearle]

@crablab this all looks good. It's currently blocked by jac-uk/digital-platform#334 which is now in progress

[crablab]

@warrensearle Yup! As noted above, I think once that ticket is done we can test this and PR any required changes 😄

I'll merge this now then 👍