Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrapMethod causes issues with callbacks #63

Closed
jac3km4 opened this issue Nov 29, 2021 · 2 comments
Closed

wrapMethod causes issues with callbacks #63

jac3km4 opened this issue Nov 29, 2021 · 2 comments

Comments

@jac3km4
Copy link
Owner

jac3km4 commented Nov 29, 2021

  • @wrapMethod creates one method for every wrapper, but it looks like the game invokes every cb method on a class, so all of the wrappers get invoked
  • cb methods should take exactly one argument and it's type should extend Event, this could be enforced by the compiler
jac3km4 added a commit that referenced this issue Jan 1, 2022
@psiberx
Copy link

psiberx commented Jan 1, 2022

cb methods can have different signatures, Event based callback is just one variation that can cause issues with wrappers

@jac3km4
Copy link
Owner Author

jac3km4 commented Jan 2, 2022

the main issue has been adressed in a6a22cf

@jac3km4 jac3km4 closed this as completed Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants