Handle missing attributes before Python 3.10

jacebrowning · Jul 28, 2022 · 1fdd8fd · 1fdd8fd
1 parent 3be02b7
commit 1fdd8fd
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/datafiles/converters/containers.py b/datafiles/converters/containers.py
@@ -129,7 +129,10 @@ class Dictionary(Converter):
 
     @classmethod
     def of_mapping(cls, key: type, value: type):
-        name = f"{key.__name__}{value.__name__}Dict"
+        try:
+            name = f"{key.__name__}{value.__name__}Dict"
+        except AttributeError:  # Python < 3.10
+            name = "UntypedDict"
         bases = (cls,)
         return type(name, bases, {})
 

diff --git a/datafiles/tests/__init__.py b/datafiles/tests/__init__.py
@@ -8,3 +8,8 @@
     sys.version_info < (3, 10),
     reason="Union types (PEP 604) are not available in Python 3.9 and earlier",
 )
+
+xfail_without_type_names = pytest.mark.xfail(
+    sys.version_info < (3, 10),
+    reason="Types lack a __name__ in Python 3.9 and earlier",
+)
diff --git a/datafiles/tests/test_converters.py b/datafiles/tests/test_converters.py
@@ -10,7 +10,7 @@
 
 from datafiles import converters, settings
 
-from . import xfail_without_pep_604
+from . import xfail_without_pep_604, xfail_without_type_names
 
 
 @dataclass
@@ -95,6 +95,7 @@ def it_requires_dict_annotations_to_have_types(expect):
         with expect.raises(TypeError, "Types are required with 'Dict' annotation"):
             converters.map_type(Dict)
 
+    @xfail_without_type_names
     def it_handles_typed_dict_annotations(expect):
         converter = converters.map_type(MyTypedDict)
         expect(converter.__name__) == "StringAnyDict"