Refactor code to support realtime streaming of shell output #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacebrowning
commented
Aug 26, 2020
| :param _shell: force executing the program into a real shell | ||
| a Windows shell command (i.e: dir, echo) needs a real shell | ||
| but not a regular program (i.e: calc, git) | ||
| :param _ignore: ignore non-zero return codes | ||
| """ | ||
| if not _show: | ||
| _stream = False |
There was a problem hiding this comment.
The goal here is to avoid passing an extra argument in places where its value can be inferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @spurnvoj since I'm modifying some of your code to get this ready for release.