Split up API tests

app/tests/test_apis_extras.py

@@ -0,0 +1,140 @@
+import pytest
+
+from .. import settings
+
+
+def describe_preview():
+    @pytest.fixture
+    def path():
+        return "/images/preview.jpg"
+
+    def it_returns_an_image(expect, client, path):
+        request, response = client.get(path)
+        expect(response.status) == 200
+        expect(response.headers["content-type"]) == "image/jpeg"
+
+    def it_supports_custom_templates(expect, client, path):
+        request, response = client.get(
+            path + "?template=https://www.gstatic.com/webp/gallery/1.png"
+        )
+        expect(response.status) == 200
+        expect(response.headers["content-type"]) == "image/jpeg"
+
+    def it_handles_invalid_urls(expect, client, path):
+        request, response = client.get(path + "?template=http://example.com/foobar.jpg")
+        expect(response.status) == 200
+        expect(response.headers["content-type"]) == "image/jpeg"
+
+    def it_handles_invalid_keys(expect, client, path, unknown_template):
+        request, response = client.get(path + f"?template={unknown_template.key}")
+        expect(response.status) == 200
+        expect(response.headers["content-type"]) == "image/jpeg"
+
+
+def describe_redirects():
+    @pytest.mark.parametrize("ext", ["png", "jpg"])
+    def it_redirects_to_normalized_slug(expect, client, ext):
+        request, response = client.get(
+            f"/images/fry/One Two.{ext}", allow_redirects=False
+        )
+        expect(response.status) == 301
+        expect(response.headers["Location"]) == f"/images/fry/One_Two.{ext}"
+
+    @pytest.mark.parametrize("ext", ["png", "jpg"])
+    def it_preserves_query_params_when_redirecting(expect, client, ext):
+        request, response = client.get(
+            f"/images/custom/One Two.{ext}?alt=http://example.com",
+            allow_redirects=False,
+        )
+        redirect = f"/images/custom/One_Two.{ext}?alt=http://example.com"
+        expect(response.status) == 301
+        expect(response.headers["Location"]) == redirect
+
+    def it_handles_encoded_newlines(expect, client):
+        request, response = client.get("/images/fry/1 2%0A3.jpg", allow_redirects=False)
+        redirect = "/images/fry/1_2~n3.jpg"
+        expect(response.status) == 301
+        expect(response.headers["Location"]) == redirect
+
+
+def describe_shortcuts():
+    def it_redirects_to_example_image_when_no_extension(expect, client):
+        request, response = client.get("/images/fry", allow_redirects=False)
+        redirect = "/images/fry/not_sure_if_trolling/or_just_stupid"
+        expect(response.status) == 302
+        expect(response.headers["Location"]) == redirect
+
+    def it_redirects_to_custom_image_when_no_extension(expect, client):
+        request, response = client.get("/images/fry/test", allow_redirects=False)
+        expect(response.status) == 302
+        expect(response.headers["Location"]) == "/images/fry/test.png"
+
+    def it_returns_gallery_view_when_debug(expect, client, monkeypatch):
+        monkeypatch.setattr(settings, "DEBUG", True)
+        request, response = client.get("/images/fry/test")
+        expect(response.text).contains("/images/fry/test.png")
+
+    def it_rejects_unknown_templates(expect, client, unknown_template):
+        request, response = client.get(
+            f"/images/{unknown_template.key}", allow_redirects=False
+        )
+        expect(response.status) == 404
+
+    def it_creates_new_templates_when_debug(
+        expect, client, unknown_template, monkeypatch
+    ):
+        monkeypatch.setattr(settings, "DEBUG", True)
+        request, response = client.get(
+            f"/images/{unknown_template.key}", allow_redirects=False
+        )
+        expect(response.status) == 501
+
+    def it_handles_sample_templates(expect, client, monkeypatch):
+        monkeypatch.setattr(settings, "DEBUG", True)
+        request, response = client.get(f"/images/<sample>", allow_redirects=False)
+        expect(response.status) == 501
+
+
+def describe_legacy():
+    @pytest.mark.slow
+    def it_accepts_alt_for_template(expect, client):
+        request, response = client.get(
+            "/images/custom/test.png" "?alt=https://www.gstatic.com/webp/gallery/3.jpg"
+        )
+        expect(response.status) == 200
+        expect(response.headers["content-type"]) == "image/png"
+
+    @pytest.mark.slow
+    def it_accepts_alt_for_style(expect, client):
+        request, response = client.get("/images/sad-biden/test.png?style=scowl")
+        expect(response.status) == 200
+
+        request, response2 = client.get("/images/sad-biden/test.png?alt=scowl")
+        expect(response.status) == 200
+
+        expect(len(response.content)) == len(response2.content)
+
+    @pytest.mark.parametrize("ext", ["png", "jpg"])
+    def it_redirects_to_example_image(expect, client, ext):
+        request, response = client.get(f"/fry.{ext}", allow_redirects=False)
+        redirect = f"/images/fry/not_sure_if_trolling/or_just_stupid.{ext}"
+        expect(response.status) == 302
+        expect(response.headers["Location"]) == redirect
+
+    @pytest.mark.parametrize("ext", ["png", "jpg"])
+    def it_redirects_to_custom_image(expect, client, ext):
+        request, response = client.get(f"/fry/test.{ext}", allow_redirects=False)
+        expect(response.status) == 302
+        expect(response.headers["Location"]) == f"/images/fry/test.{ext}"
+
+    @pytest.mark.parametrize("suffix", ["", ".png", ".jpg"])
+    def it_rejects_unknown_templates(expect, client, unknown_template, suffix):
+        request, response = client.get(f"/{unknown_template.key}{suffix}")
+        expect(response.status) == 404
+
+    @pytest.mark.parametrize("suffix", ["", ".png", ".jpg"])
+    def it_rejects_unknown_templates_with_text(
+        expect, client, unknown_template, suffix
+    ):
+        request, response = client.get(f"/{unknown_template.key}/test{suffix}")
+        expect(response.status) == 404

app/tests/test_apis.py → app/tests/test_apis_images.py

@@ -5,77 +5,7 @@
 from .. import settings
 
 
-def describe_template_list():
-    def describe_GET():
-        @pytest.mark.slow
-        def it_returns_all_templates(expect, client):
-            request, response = client.get("/templates")
-            expect(response.status) == 200
-
-
-def describe_template_detail():
-    def describe_GET():
-        def it_includes_metadata(expect, client):
-            request, response = client.get("/templates/iw")
-            expect(response.status) == 200
-            expect(response.json) == {
-                "name": "Insanity Wolf",
-                "key": "iw",
-                "lines": 2,
-                "styles": [],
-                "blank": "http://localhost:5000/images/iw.png",
-                "example": "http://localhost:5000/images/iw/does_testing/in_production.png",
-                "source": "http://knowyourmeme.com/memes/insanity-wolf",
-                "_self": "http://localhost:5000/templates/iw",
-            }
-
-        def it_shortens_example_when_no_text(expect, client):
-            request, response = client.get("/templates/mmm")
-            expect(response.status) == 200
-            expect(response.json["example"]) == "http://localhost:5000/images/mmm.png"
-
-        def it_returns_404_when_missing(expect, client):
-            request, response = client.get("/templates/foobar")
-            expect(response.status) == 404
-
-    def describe_POST():
-        @pytest.mark.parametrize("as_json", [True, False])
-        def it_returns_an_image_url(expect, client, as_json):
-            data = {"text_lines[]": ["foo", "bar"], "extension": "jpg"}
-            request, response = client.post(
-                "/templates/iw", data=json.dumps(data) if as_json else data
-            )
-            expect(response.status) == 201
-            expect(response.json) == {
-                "url": "http://localhost:5000/images/iw/foo/bar.jpg"
-            }
-
-        @pytest.mark.parametrize("as_json", [True, False])
-        def it_supports_custom_backgrounds(expect, client, as_json):
-            data = {
-                "image_url": "https://www.gstatic.com/webp/gallery/3.png",
-                "text_lines[]": ["foo", "bar"],
-                "extension": "jpg",
-            }
-            request, response = client.post(
-                "/templates/custom", data=json.dumps(data) if as_json else data
-            )
-            expect(response.status) == 201
-            expect(response.json) == {
-                "url": "http://localhost:5000/images/custom/foo/bar.jpg"
-                "?background=https://www.gstatic.com/webp/gallery/3.png"
-            }
-
-        @pytest.mark.parametrize("key", ["fry", "custom"])
-        def it_redirects_if_requested(expect, client, key):
-            data = {"text_lines": ["abc"], "redirect": True}
-            request, response = client.post(
-                f"/templates/{key}", data=data, allow_redirects=False
-            )
-            expect(response.status) == 302
-
-
-def describe_image_list():
+def describe_list():
     def describe_GET():
         @pytest.mark.slow
         def it_returns_example_image_urls(expect, client):
@@ -160,7 +90,7 @@ def it_handles_invalid_keys(expect, client, path, unknown_template):
         expect(response.headers["content-type"]) == "image/jpeg"
 
 
-def describe_image_detail():
+def describe_detail():
     @pytest.mark.parametrize(
         ("path", "content_type"),
         [
@@ -274,112 +204,3 @@ def it_handles_missing_urls(expect, client):
             )
             expect(response.status) == 415
             expect(response.headers["content-type"]) == "image/png"
-
-    def describe_redirects():
-        @pytest.mark.parametrize("ext", ["png", "jpg"])
-        def it_redirects_to_normalized_slug(expect, client, ext):
-            request, response = client.get(
-                f"/images/fry/One Two.{ext}", allow_redirects=False
-            )
-            expect(response.status) == 301
-            expect(response.headers["Location"]) == f"/images/fry/One_Two.{ext}"
-
-        @pytest.mark.parametrize("ext", ["png", "jpg"])
-        def it_preserves_query_params_when_redirecting(expect, client, ext):
-            request, response = client.get(
-                f"/images/custom/One Two.{ext}?alt=http://example.com",
-                allow_redirects=False,
-            )
-            redirect = f"/images/custom/One_Two.{ext}?alt=http://example.com"
-            expect(response.status) == 301
-            expect(response.headers["Location"]) == redirect
-
-        def it_handles_encoded_newlines(expect, client):
-            request, response = client.get(
-                "/images/fry/1 2%0A3.jpg", allow_redirects=False
-            )
-            redirect = "/images/fry/1_2~n3.jpg"
-            expect(response.status) == 301
-            expect(response.headers["Location"]) == redirect
-
-    def describe_shortcuts():
-        def it_redirects_to_example_image_when_no_extension(expect, client):
-            request, response = client.get("/images/fry", allow_redirects=False)
-            redirect = "/images/fry/not_sure_if_trolling/or_just_stupid"
-            expect(response.status) == 302
-            expect(response.headers["Location"]) == redirect
-
-        def it_redirects_to_custom_image_when_no_extension(expect, client):
-            request, response = client.get("/images/fry/test", allow_redirects=False)
-            expect(response.status) == 302
-            expect(response.headers["Location"]) == "/images/fry/test.png"
-
-        def it_returns_gallery_view_when_debug(expect, client, monkeypatch):
-            monkeypatch.setattr(settings, "DEBUG", True)
-            request, response = client.get("/images/fry/test")
-            expect(response.text).contains("/images/fry/test.png")
-
-        def it_rejects_unknown_templates(expect, client, unknown_template):
-            request, response = client.get(
-                f"/images/{unknown_template.key}", allow_redirects=False
-            )
-            expect(response.status) == 404
-
-        def it_creates_new_templates_when_debug(
-            expect, client, unknown_template, monkeypatch
-        ):
-            monkeypatch.setattr(settings, "DEBUG", True)
-            request, response = client.get(
-                f"/images/{unknown_template.key}", allow_redirects=False
-            )
-            expect(response.status) == 501
-
-        def it_handles_sample_templates(expect, client, monkeypatch):
-            monkeypatch.setattr(settings, "DEBUG", True)
-            request, response = client.get(f"/images/<sample>", allow_redirects=False)
-            expect(response.status) == 501
-
-    def describe_legacy():
-        @pytest.mark.slow
-        def it_accepts_alt_for_template(expect, client):
-            request, response = client.get(
-                "/images/custom/test.png"
-                "?alt=https://www.gstatic.com/webp/gallery/3.jpg"
-            )
-            expect(response.status) == 200
-            expect(response.headers["content-type"]) == "image/png"
-
-        @pytest.mark.slow
-        def it_accepts_alt_for_style(expect, client):
-            request, response = client.get("/images/sad-biden/test.png?style=scowl")
-            expect(response.status) == 200
-
-            request, response2 = client.get("/images/sad-biden/test.png?alt=scowl")
-            expect(response.status) == 200
-
-            expect(len(response.content)) == len(response2.content)
-
-        @pytest.mark.parametrize("ext", ["png", "jpg"])
-        def it_redirects_to_example_image(expect, client, ext):
-            request, response = client.get(f"/fry.{ext}", allow_redirects=False)
-            redirect = f"/images/fry/not_sure_if_trolling/or_just_stupid.{ext}"
-            expect(response.status) == 302
-            expect(response.headers["Location"]) == redirect
-
-        @pytest.mark.parametrize("ext", ["png", "jpg"])
-        def it_redirects_to_custom_image(expect, client, ext):
-            request, response = client.get(f"/fry/test.{ext}", allow_redirects=False)
-            expect(response.status) == 302
-            expect(response.headers["Location"]) == f"/images/fry/test.{ext}"
-
-        @pytest.mark.parametrize("suffix", ["", ".png", ".jpg"])
-        def it_rejects_unknown_templates(expect, client, unknown_template, suffix):
-            request, response = client.get(f"/{unknown_template.key}{suffix}")
-            expect(response.status) == 404
-
-        @pytest.mark.parametrize("suffix", ["", ".png", ".jpg"])
-        def it_rejects_unknown_templates_with_text(
-            expect, client, unknown_template, suffix
-        ):
-            request, response = client.get(f"/{unknown_template.key}/test{suffix}")
-            expect(response.status) == 404