Refactor sample image data generation

memegen/routes/_common.py

@@ -1,5 +1,6 @@
 from urllib.parse import unquote
 
+from flask import current_app as app
 from flask import url_for as _url_for
 
 
@@ -10,3 +11,15 @@
 def url_for(*args, **kwargs):
     """Unquoted version of Flask's `url_for`."""
     return unquote(_url_for(*args, **kwargs))
+
+
+def samples():
+    """Generate dictionaries of sample image data for template rendering."""
+    for template in sorted(app.template_service.all()):
+        path = template.sample_path
+        url = url_for("image.get", key=template.key, path=path, _external=True)
+        link = url_for("links.get", key=template.key, path=path)
+        yield {
+            'url': url,
+            'link': link
+        }

memegen/routes/overview.py

@@ -1,25 +1,14 @@
-from flask import Blueprint, current_app as app, render_template
+from flask import Blueprint, render_template
 from flask_api.decorators import set_renderers
 from flask_api.renderers import HTMLRenderer
 
-from ._common import url_for
+from ._common import samples
 
 
 blueprint = Blueprint('overview', __name__, url_prefix="/overview")
 
 
-def _gen():
-    for template in sorted(app.template_service.all()):
-        path = template.sample_path
-        url = url_for("image.get", key=template.key, path=path, _external=True)
-        link = url_for("links.get", key=template.key, path=path)
-        yield {
-            'url': url,
-            'link': link
-        }
-
-
 @blueprint.route("")
 @set_renderers(HTMLRenderer)
 def get():
-    return render_template('overview.html', imgs=_gen())
+    return render_template('overview.html', imgs=samples())