Merge pull request #738 from jacebrowning/debug-config

Make DEBUG configurable
jacebrowning · Aug 13, 2022 · 68e9d32 · 68e9d32
2 parents a09f867 + fb2102e
commit 68e9d32
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 2 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -35,6 +35,7 @@
     "getbbox",
     "getenv",
     "getoffset",
+    "getplugin",
     "gjpqy",
     "Googlebot",
     "Groupon",
@@ -66,6 +67,7 @@
     "Panik",
     "Philosoraptor",
     "Photoshop",
+    "pluginmanager",
     "podman",
     "PYTHONASYNCIODEBUG",
     "PYTHONUNBUFFERED",

diff --git a/Makefile b/Makefile
@@ -144,3 +144,4 @@ promote: install .envrc
 	echo >> $@
 	echo "export CF_API_KEY=???" >> $@
 	echo "export REMOTE_TRACKING_URL=???" >> $@
+	echo "export DEBUG=true" >> $@
diff --git a/Procfile.dev b/Procfile.dev
@@ -1,2 +1,2 @@
-api: DEBUG=true PYTHONUNBUFFERED=1 PYTHONASYNCIODEBUG=1 python app/main.py
+api: DEBUG="${DEBUG:-true}" PYTHONUNBUFFERED=1 PYTHONASYNCIODEBUG=1 python app/main.py
 site: mkdocs serve --dev-addr localhost:5001
diff --git a/app/main.py b/app/main.py
@@ -43,6 +43,7 @@ async def robots(request):
         host="0.0.0.0",
         port=5000,
         debug=settings.DEBUG,
+        auto_reload=True,
         access_log=False,
         motd=False,
         fast=True,

diff --git a/app/settings.py b/app/settings.py
@@ -7,7 +7,7 @@
 
 # Server configuration
 
-DEBUG = bool(os.environ.get("DEBUG", False))
+DEBUG = os.environ.get("DEBUG", "false") == "true"
 
 if "DOMAIN" in os.environ:  # staging / production
     SERVER_NAME = os.environ["DOMAIN"]

diff --git a/app/tests/conftest.py b/app/tests/conftest.py
@@ -11,6 +11,7 @@ def pytest_configure(config):
     terminal = config.pluginmanager.getplugin("terminal")
     terminal.TerminalReporter.showfspath = False
     settings.ALLOWED_EXTENSIONS.append("apng")
+    settings.DEBUG = False
 
 
 def pytest_runtest_setup(item):