Merge pull request #194 from jacebrowning/appveyor

Enable Appveyor to test Windows compatiblity

.appveyor.yml

@@ -0,0 +1,15 @@
+cache:
+  - env
+
+install:
+  # Export build paths
+  - copy C:\MinGW\bin\mingw32-make.exe C:\MinGW\bin\make.exe
+  - set PATH=%PATH%;C:\MinGW\bin
+  - make --version
+  # Install project dependenies
+  - make depends-ci
+
+build: off
+
+test_script:
+  - make ci

.pep8rc

@@ -2,4 +2,5 @@
 
 # E501: line too long (checked by PyLint)
 # E711: comparison to None (used to improve test style)
-ignore = E501,E711
+# E712: comparison to True (used to improve test style)
+ignore = E501,E711,E712

Makefile

@@ -159,7 +159,9 @@ $(INSTALLED_FLAG): Makefile setup.py requirements.txt
 
 $(PIP):
 	$(SYS_PYTHON) -m venv --clear $(ENV)
+ifndef APPVEYOR
 	$(PIP) install --upgrade pip setuptools
+endif
 
 # Tools Installation ###########################################################
 
@@ -281,25 +283,31 @@ test-unit: depends-ci
 	$(PYTEST) $(PYTEST_OPTS) $(PACKAGE)
 	@- mv $(FAILURES).bak $(FAILURES)
 ifndef TRAVIS
+ifndef APPVEYOR
 	$(COVERAGE_SPACE) jacebrowning/memegen unit
 endif
+endif
 
 .PHONY: test-int
 test-int: depends-ci
 	@ if test -e $(FAILURES); then $(PYTEST) $(PYTEST_OPTS_FAILFAST) tests; fi
 	$(PYTEST) $(PYTEST_OPTS) tests
 ifndef TRAVIS
+ifndef APPVEYOR
 	$(COVERAGE_SPACE) jacebrowning/memegen integration
 endif
+endif
 
 .PHONY: tests test-all
 tests: test-all
 test-all: depends-ci
 	@ if test -e $(FAILURES); then $(PYTEST) $(PYTEST_OPTS_FAILFAST) $(PACKAGE) tests; fi
 	$(PYTEST) $(PYTEST_OPTS) $(PACKAGE) tests
 ifndef TRAVIS
+ifndef APPVEYOR
 	$(COVERAGE_SPACE) jacebrowning/memegen overall
 endif
+endif
 
 .PHONY: read-coverage
 read-coverage:

README.md

@@ -2,8 +2,10 @@
 
 An API to generate meme images based solely on requested URLs.
 
-[![Build Status](http://img.shields.io/travis/jacebrowning/memegen/master.svg)](https://travis-ci.org/jacebrowning/memegen)
-[![Coverage Status](http://img.shields.io/coveralls/jacebrowning/memegen/master.svg)](https://coveralls.io/r/jacebrowning/memegen)
+Unix: [![Unix Build Status](http://img.shields.io/travis/jacebrowning/memegen/master.svg)](https://travis-ci.org/jacebrowning/memegen)
+Windows: [![Windows Build Status](https://img.shields.io/appveyor/ci/jacebrowning/memegen.svg)](https://ci.appveyor.com/project/jacebrowning/memegen)
+
+Metrics: [![Coverage Status](http://img.shields.io/coveralls/jacebrowning/memegen/master.svg)](https://coveralls.io/r/jacebrowning/memegen)
 [![Scrutinizer Code Quality](http://img.shields.io/scrutinizer/g/jacebrowning/memegen.svg)](https://scrutinizer-ci.com/g/jacebrowning/memegen/?branch=master)
 
 ## Generating Images

manage.py

@@ -1,8 +1,8 @@
 #!env/bin/python
 
 import os
+import subprocess
 import logging
-from subprocess import check_output
 
 from flask_script import Manager, Server
 from flask_migrate import Migrate, MigrateCommand
@@ -21,7 +21,8 @@
 for name, command in [
     ('DEPLOY_DATE', "TZ=America/Detroit date '+%F %T'"),
 ]:
-    output = check_output(command, shell=True, universal_newlines=True).strip()
+    output = subprocess.run(command, shell=True, stdout=subprocess.PIPE,
+                            universal_newlines=True).stdout.strip() or "???"
     os.environ[name] = os.getenv(name, output)
 
 # Configure the command-line interface

memegen/domain/template.py

@@ -2,6 +2,8 @@
 import re
 import hashlib
 import shutil
+from pathlib import Path
+import tempfile
 import logging
 
 import time
@@ -109,9 +111,12 @@ def get_path(self, *styles):
 
         for name in (n.lower() for n in (*styles, self.DEFAULT) if n):
             for extension in self.EXTENSIONS:
-                path = os.path.join(self.dirpath, name + extension)
-                if os.path.isfile(path):
-                    return path
+                path = Path(self.dirpath, name + extension)
+                try:
+                    if path.is_file():
+                        return path
+                except OSError:
+                    continue
 
         return None
 
@@ -164,13 +169,13 @@ def validate_meta(self):
 
     def validate_link(self):
         if self.link:
-            flag = os.path.join(self.dirpath, self.VALID_LINK_FLAG)
-            if os.path.isfile(flag):
+            flag = Path(self.dirpath, self.VALID_LINK_FLAG)
+            if flag.is_file():
                 log.info("Link already checked: %s", self.link)
             else:
                 log.info("Checking link %s ...", self.link)
                 try:
-                    response = requests.get(self.link, timeout=5)
+                    response = requests.head(self.link, timeout=5)
                 except requests.exceptions.ReadTimeout:
                     log.warning("Connection timed out")
                     return True  # assume URL is OK; it will be checked again
@@ -180,7 +185,7 @@ def validate_link(self):
                     self._error("link is invalid (%s)", response.status_code)
                     return False
                 else:
-                    with open(flag, 'w') as stream:
+                    with open(str(flag), 'w') as stream:
                         stream.write(str(int(time.time())))
         return True
 
@@ -237,9 +242,10 @@ def download_image(url):
     if not url or not url.startswith("http"):
         return None
 
-    # /tmp is detroyed after every Heroku request
-    path = "/tmp/" + hashlib.md5(url.encode('utf-8')).hexdigest()
-    if os.path.isfile(path):
+    path = Path(tempfile.gettempdir(),
+                hashlib.md5(url.encode('utf-8')).hexdigest())
+
+    if path.is_file():
         log.debug("Already downloaded: %s", url)
         return path
 
@@ -254,7 +260,7 @@ def download_image(url):
 
     if response.status_code == 200:
         log.info("Downloading %s", url)
-        with open(path, 'wb') as outfile:
+        with open(str(path), 'wb') as outfile:
             response.raw.decode_content = True
             shutil.copyfileobj(response.raw, outfile)
         return path

memegen/stores/image.py

@@ -1,6 +1,8 @@
 # pylint: disable=no-member
 
 import os
+import shutil
+from contextlib import suppress
 import logging
 
 import sqlalchemy as sa
@@ -84,13 +86,14 @@ def create(self, image):
         if self.exists(image) and not self.regenerate_images:
             return
 
-        ImageModel(image)
+        try:
+            ImageModel(image)
+        except ImportError:
+            log.warning("Unable to store models on this machine")
 
         image.root = self.root
         image.generate()
 
-        try:
+        with suppress(IOError):
             os.remove(self.latest)
-        except IOError:
-            pass
-        os.symlink(image.path, self.latest)
+        shutil.copy(image.path, self.latest)