Handle backgrounds lacking an extension

jacebrowning · Aug 6, 2022 · e48df4e · e48df4e
1 parent 2630f6b
commit e48df4e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/app/models/template.py b/app/models/template.py
@@ -206,7 +206,8 @@ def build_custom_url(
                     text_lines[index] = text.normalize(text_lines[index])
         if not extension and background:
             url = furl(background)
-            extension = url.path.segments[-1].split(".")[-1]
+            if url.path.segments:
+                extension = url.path.segments[-1].split(".")[-1]
         if extension not in settings.ALLOWED_EXTENSIONS:
             extension = self._extension
         if style == "default":

diff --git a/app/tests/test_views_images.py b/app/tests/test_views_images.py
@@ -427,16 +427,15 @@ def describe_POST():
         @pytest.mark.parametrize("as_json", [True, False])
         def it_supports_custom_backgrounds(expect, client, as_json):
             data = {
-                "background": "https://www.gstatic.com/webp/gallery/3.png",
+                "background": "http://example.com",
                 "text_lines[]": ["foo", "bar"],
-                "extension": "jpg",
             }
             kwargs: dict = {"content": json.dumps(data)} if as_json else {"data": data}
             request, response = client.post("/images/custom", **kwargs)
             expect(response.status) == 201
             expect(response.json) == {
-                "url": "http://localhost:5000/images/custom/foo/bar.jpg"
-                "?background=https://www.gstatic.com/webp/gallery/3.png"
+                "url": "http://localhost:5000/images/custom/foo/bar.png"
+                "?background=http://example.com"
             }
 
         def it_returns_gif_when_background_is_gif(expect, client):