Support separate font sizes #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 27, 2015 11:44
Currently defaults to forcing font sizes to be the same but can size top and bottom fonts separately
Conflicts: memegen/domain/image.py
|
Some of the text runs off the image: http://instantmeme-pr-101.herokuapp.com/overview |
If the line was multiple lines, then only the second line was determining the font size. So in the case where the first line was longer, it would extend past the image. Changed the max font size to be different for multiline text, this should prevent text from taking up too much vertical space when the phrase was just long enough to be split.
|
This looks good! |
jacebrowning
added a commit
that referenced
this pull request
Sep 5, 2020
Fix loading of model defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.