add loading gif while meme loads #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason this shouldn't work, but I when I tried to test this, It turned out (pls no hate) that my internet is too fast. I wasn't able to see what happened when memes were loading because it happened too fast. But, i've used this method before, and it has worked.
|
One possible way to test this is to simulate high latency using Chrome developer tools:
I'll check it out... |
|
Nice I didn't know that. Useful. |
|
I'm not seeing any loading GIFs with the deployed Heroku review app and simulated latency:
|
|
I will do some code things and work on this. Stay tuned. Will this heroku deploy stay up to date with my patch branch? |
|
Alright! everything is working now! |
|
Can you attach a screenshot of what the spinner looks like when the page is loading? I still just see an empty white background as the grid of images loads. Also, you need to rebase on |
|
@jacebrowning when i squashed i used the wrong head and overwrote my changes :) |
|
im going to open another pr with fewer squash issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason this shouldn't work, but I when I tried to test this, It turned out (pls no hate) that my internet is too fast. I wasn't able to see what happened when memes were loading because it happened too fast. But, i've used this method before, and it has worked.
Also, closes #196