Getting the (first) changes from Ranjith #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jachin
commented
Oct 20, 2023
site/demo-styles.css
Outdated
| margin: 0; | ||
|
|
||
| /* Keep input filter's text from running over the dropdown indicator. */ | ||
| padding: 0 0.8em 0 0; | ||
| padding: 0 0.8em 0 10px; | ||
| border-right: 2px dotted #D0D4CA; |
There was a problem hiding this comment.
This color should be defined by a variable.
site/demo-styles.css
Outdated
| } | ||
|
|
||
| much-select::part(dropdown-option) { | ||
| background-color: var(--much-select-dropdown-option-background-color); | ||
| background-color: #f1f1f1; |
There was a problem hiding this comment.
This color should be defined by a variable.
| border: 3px solid black; | ||
| min-width: 10px; | ||
|
|
||
| border: 2px solid black; |
There was a problem hiding this comment.
(I know you didn't do this Ranjith but this color, in fact probably this whole border definition should be defined in a variable.
src/much-select.js
Outdated
| @@ -1829,6 +1829,27 @@ class MuchSelect extends HTMLElement { | |||
| 0% { transform: rotate(0); } | |||
| 100% { transform: rotate(360deg); } | |||
| } | |||
| #wrapper .error-message ul li{ | |||
| color:red; | |||
There was a problem hiding this comment.
This color should be in a variable.
src/much-select.js
Outdated
| padding-left: 5px; | ||
| margin-left:6px; | ||
| padding-bottom:3px; | ||
| border-left: 1px dotted #718093; |
There was a problem hiding this comment.
This border definition should be in a variable.
I refactored how the "parts" attribute is figured out for each dropdown item.
The selected-value part should be different from the dropdown-items.
Not so much the styling but putting in place the CSS hooks to hand the styling on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of work trying to make the styling better.
There is still a loooong way to go.