Adding UncheckedIOException to onFailure handler #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardo-mestre
force-pushed
the
propagate-io-exception
branch
4 times, most recently
from
8c3e8f7
to
3f7233a
Compare
jack-berg
reviewed
Dec 20, 2023
exporters/common/src/main/java/io/opentelemetry/exporter/internal/http/HttpExporter.java
Outdated
Show resolved
Hide resolved
jack-berg
reviewed
Dec 20, 2023
.../okhttp/src/main/java/io/opentelemetry/exporter/sender/okhttp/internal/OkHttpHttpSender.java
Outdated
Show resolved
Hide resolved
ricardo-mestre
force-pushed
the
propagate-io-exception
branch
4 times, most recently
from
bbf0c5b
to
83637b5
Compare
ricardo-mestre
force-pushed
the
propagate-io-exception
branch
from
83637b5
to
0accdf3
Compare
jack-berg
reviewed
Dec 20, 2023
exporters/common/src/main/java/io/opentelemetry/exporter/internal/http/HttpExporter.java
Outdated
Show resolved
Hide resolved
jack-berg
reviewed
Dec 20, 2023
| CompletableResultCode result = exporter.export(new NoOpMarshaler(), 0); | ||
| result.join(1, TimeUnit.MINUTES); | ||
| exporter.shutdown().join(1, TimeUnit.MINUTES); | ||
| Assertions.assertThat(result.isSuccess()).isTrue(); |
There was a problem hiding this comment.
Not sure what this test has to do with the code we've been talking about.
There was a problem hiding this comment.
I intend to cover Lines 220 and 221 of JdkHttpSender. I can't override the method writeJsonTo on the NoOpMarshaler so I'm using a succes flow instead adding .exportAsJson() in the builder.
There was a problem hiding this comment.
Just removed the authentication and shutdown part to focus more on the regular success flow
…nal/http/HttpExporter.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
ricardo-mestre
force-pushed
the
propagate-io-exception
branch
from
9c2fc38
to
4600eea
Compare
jack-berg
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.