Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace PyXDG module with appdirs #150

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Replace PyXDG module with appdirs #150

merged 1 commit into from
Oct 22, 2021

Conversation

markk
Copy link
Contributor

@markk markk commented Oct 20, 2021

appdirs returns appropriate platform-specific directories for saving user
preferences and data.

Replace PyXDG module with appdirs
0f30b8a 
`appdirs` returns appropriate platform-specific directories for saving user
preferences and data.
SpotlightKid
SpotlightKid approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@SpotlightKid SpotlightKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@SpotlightKid
Copy link
Contributor

Please tell us, how you want to be listed in the AUTHORS file.

@markk
Copy link
Contributor Author

markk commented Oct 21, 2021

Thanks!

Mark Knoop mark@opus11.net

dsheeler
dsheeler reviewed Oct 21, 2021
View reviewed changes
Copy link
Member

@dsheeler dsheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this pr, we used the same directory for the preferences.ini and the session xml files. Is it more correct to store the xml files in the data dir and the preferences.ini in the config dir?

dsheeler
dsheeler reviewed Oct 21, 2021
View reviewed changes
Copy link
Member

@dsheeler dsheeler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my above question, it looks good!

@SpotlightKid
Copy link
Contributor

If we change the path for the .xml files that should probably go into a separate PR.

We might then also need some kind of migration strategy.

@dsheeler
Copy link
Member

@SpotlightKid the PR as it is does look for and save xml files to the data dir and the preferences.ini goes to the config dir, where the xml files used to be. I tried this out and was surprised my session files weren't found.

dsheeler
dsheeler approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@dsheeler dsheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies. I retract all of my comments about behaviour changing with this PR. The locations of the xml files and preferences.ini remain the same. My bad!

@dsheeler dsheeler merged commit 5f3295e into jack-mixer:main Oct 22, 2021
@SpotlightKid SpotlightKid mentioned this pull request Oct 22, 2021
Open
@markk markk deleted the appdirs branch October 25, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsheeler dsheeler dsheeler approved these changes

@SpotlightKid SpotlightKid SpotlightKid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markk @SpotlightKid @dsheeler