-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Move to .NET Standard 2.0 #27
WIP Move to .NET Standard 2.0 #27
Conversation
This is great! Thanks Vasily! Let me take a look over it today and tomorrow. The one test that's failing is a known bug in the implementation of the |
About the issue with duplicated |
Apparently NUnit Core test adapter does not support 2.0 nunit/dotnet-test-nunit#122 |
…r to enable "dotnet test"
AppVeyor tries to build it with msbuild 12 and fails. |
It installs .net core 2.0, builds the solution and run the tests on Core. All on Windows. I don't know what to do next. |
Thanks Vasily! I've merged your changes. I think I need to make a few more tweaks to the build process, but I'll work on it today. (A few things in ExtCore use F# features restricted to FSharp.Core and require |
Thanks! |
Open issues:
ofAsyncSeq
:This is an interesting issue:
Seq
module is defined twice inExtCore.Collections
namespace, once with ModuleSuffix attribute and once - without it:Collections.Seq.fs
Collections.AsyncSeq.fs
I've commented out
ofAsyncSeq
and it's fixed the compilation. I suspect it's a regression in F# 4.1/cc @dsyme
dotnet pack
inExtCore
folder successfully creates NuGet package:I'd like to hear what do you guys thought of all this. Is this the right direction? Have I done everything properly? Thanks!