Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long load times for logs #22

Closed
jack-ullery opened this issue May 12, 2022 · 2 comments · Fixed by #30 or #41
Closed

Long load times for logs #22

jack-ullery opened this issue May 12, 2022 · 2 comments · Fixed by #30 or #41
Labels
bug Something isn't working

Comments

@jack-ullery
Copy link
Owner

Describe the bug
The Logs tab usually takes a while to load (and refresh). This is because it calls journalctl every 5 seconds to parse all the system logs.

To Reproduce
Steps to reproduce the behavior:

  1. Build and run AppAnvil
  2. Click on the Logs tab on the top of the screen
  3. Observe that it takes a significant amount of time for the logs to load

Expected behavior
The Logs tab should display some information relatively quickly, within a couple of seconds. We also don't need to refresh the entire cache of logs every few seconds. We only really need to check for the next set of logs, that might've been sent in the time since the last refresh.

Additional context
We could also parse the logs in batches. For example, we may be able to add logs in batches of 1,000.

@jack-ullery jack-ullery added the bug Something isn't working label May 12, 2022
jack-ullery added a commit that referenced this issue Jun 21, 2022
@jack-ullery
Copy link
Owner Author

Solved with PR #30

@jack-ullery jack-ullery linked a pull request Jul 3, 2022 that will close this issue
@jack-ullery jack-ullery linked a pull request Oct 16, 2022 that will close this issue
@jack-ullery
Copy link
Owner Author

jack-ullery commented Oct 16, 2022

Further improvements with PR #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant