Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stanncam methods to support method chaining #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bfrymire
Copy link
Collaborator

Fixes #79

@jack27121
Copy link
Owner

looks gtm, but let's merge it to a new minor version branch.
With this being a feature we could also simplify the creation of new stanncams. Like instead of having so many extra optional paramters, i'd favor not having those params, but just calling whatever you need to change afterwards in a chain

@bfrymire
Copy link
Collaborator Author

Makes sense to bundle it with more updates.
So now the question is, do we add getter and setter methods for every stanncam variable? That way there's not a mix of method chaining and dot accessors when creating the stanncam?

@jack27121
Copy link
Owner

jack27121 commented May 14, 2024

Makes sense to bundle it with more updates. So now the question is, do we add getter and setter methods for every stanncam variable? That way there's not a mix of method chaining and dot accessors when creating the stanncam?

I guess that makes most sense. I feel a little conflicted since it might overcomplicate just getting a single variable with a dot accessor. But i don't know if there's any real cases where people actually do that now that i think about it. Plus this doesn't remove that ability i guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Method Chaining
2 participants