Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull node version from .nvmrc #1

Closed
jaythomas opened this issue Jul 16, 2021 · 1 comment
Closed

Pull node version from .nvmrc #1

jaythomas opened this issue Jul 16, 2021 · 1 comment

Comments

@jaythomas
Copy link

For those not using docker, it would be nice to have a .nvmrc file that gets picked up by fnm/nvm so the app can run locally and ensure I'm developing with a compatible version of node. Likewise, the Dockerfile which currently has a node version hardcoded could instead use the .nvmrc file too along with fnm to automatically install the correct version of node during container setup.

@jackadamson
Copy link
Owner

That's a good point, I've added an .nvmrc and changed the Dockerfiles to use fnm as suggested.
I hadn't heard of fnm before, but seems to work well!
Thanks for the suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants