Do change timezone of DateTime object assc. with node.

jackalope · Mar 31, 2016 · ac7db08 · ac7db08
1 parent 43fed3a
commit ac7db08
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/Jackalope/Transport/DoctrineDBAL/Client.php b/src/Jackalope/Transport/DoctrineDBAL/Client.php
@@ -1157,6 +1157,10 @@ private function propsToXML($properties)
                     }
                     foreach ((array) $values as $key => $date) {
                         if ($date instanceof \DateTime) {
+                            // do not modify the instance which is associated with the node.
+                            $date = clone $date;
+
+                            // normalize to UTC for storage.
                             $date->setTimezone(new \DateTimeZone('UTC'));
                         }
                         $values[$key] = $date;

diff --git a/tests/Jackalope/Transport/DoctrineDBAL/ClientTest.php b/tests/Jackalope/Transport/DoctrineDBAL/ClientTest.php
@@ -525,4 +525,20 @@ public function testCopy()
         $this->assertEquals($child1['props'], $child2['props']);
         $this->assertEquals($child1['numerical_props'], $child2['numerical_props']);
     }
+
+    /**
+     * The date value should not change when saving.
+     */
+    public function testDate()
+    {
+        $rootNode = $this->session->getNode('/');
+        $child1 = $rootNode->addNode('child1');
+        $date = new \DateTime();
+        $before = $date->format('c');
+        $child1->setProperty('date', $date);
+        $this->session->save();
+        $after = $date->format('c');
+
+        $this->assertEquals($before, $after);
+    }
 }