cleaned up some issues in finishSave() #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // TODO: this will need to be changed when we refactor transport to use the diff format to store changes. | ||
| if (strpos($e->getMessage(), "405") !== false && strpos($e->getMessage(), "MKCOL") !== false) { | ||
| // TODO: can the 405 exception be thrown for other reasons too? | ||
| throw new ItemExistsException('This node probably already exists: '.$node->getPath(), $e->getCode(), $e); |
There was a problem hiding this comment.
hm, this is the only thing that really changed, right? would have helped if you had committed the whitespace fix separatly ;-)
we should look at the network traffic when we try to create something that exists. the information must be somewhere, probably in the response content. maybe its all handled already by the request class evaluating the xml contained in an error reply from the backend - otherwise we would get failing tests. or did we disable some test for the jsop change?
|
any reason though to not merge this? |
|
ok |
dbu
added a commit
that referenced
this pull request
Apr 20, 2012
cleaned up some issues in finishSave()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some parts were not refactored properly .. not 100% about the changes. seems like because of jsop we cannot map a few error cases anymore.
@dbu can you have a look?