Add referer on post request for CSRF protection bypass issue #138 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! i just noticed that the master branch is 1.3 and not yet released. there are a couple of things needed until we can release 1.3, mainly releasing jackalope/jackalope 1.3 and #132. its not that easy to release a 1.2 patch version because i would need to cherry-pick quite a few commits into a 1.2 branch for that, sorting out what should go in there and what not... are you using the dev version 1.3 currently? |
|
you're right, i was working in sulu, which use the 1.2.2 version |
|
@dbu Any roadmap about the 1.3 release? This change is a really big obstacle for new developer trying jackalope... |
|
good point. currently master is failing on travis - i have to figure out why before i can tag a release. bumped my priority for this. |
|
1.3.0 is now tagged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran on issue #138 using jackrabbit 2.12.6
Tried to add Referer as proposed in the dissussion, it worked.
Here is my PR