adjust to transport interface change, for now not optimizing #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -469,9 +470,10 @@ public function getNodes($paths) | |||
|
|
|||
| $url = $this->encodeAndValidatePathForDavex("/").'.'.$this->getFetchDepth().'.json'; | |||
| foreach ($paths as $path) { | |||
| $body[] = http_build_query(array(":include" => $path)); | |||
| $body[] = http_build_query(array($query => $path)); | |||
There was a problem hiding this comment.
to allow :id or something else to fetch nodes by uuid, jackrabbit needs to have that implemented. @chregu said he might find some code laying around.
This was referenced Mar 12, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative to #33 so that we can merge jackalope/jackalope#153 now and have something that still works. then once jackrabbit starts supporting id requests, we can update without a BC break mess in jackalope.