Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more performant property updates for jackalope-doctrine-dbal #181

Closed
wants to merge 1 commit into from
Closed

more performant property updates for jackalope-doctrine-dbal #181

wants to merge 1 commit into from

Conversation

rivaros
Copy link
Contributor

@rivaros rivaros commented Jul 11, 2013

@dbu
Copy link
Member

dbu commented Jul 11, 2013

looks sane to me, but see the comment on jackalope/jackalope-doctrine-dbal#136

can you also create the PR on jackalope-jackrabbit, just moving the loop you remove here into the updateProperties method?

@lsmith77
Copy link
Member

ping

@lsmith77
Copy link
Member

We are changing the license of Jackalope. We will add the MIT license next to the Apache license. Please add a comment to this PR to state that you are ok with this licensing your submission not only under the current Apache license, but also under the MIT license.

For some more details see http://phpcr-license.davidbu.ch/licenses/projects

@dbu
Copy link
Member

dbu commented Aug 28, 2013

ping @rivaros - the license change now went through in master. please comment on this PR that you are ok with dual licensing your contributions with both MIT and Apache 2.0 license.

and any chance you could wrap this up? currently needs a rebase too.

@lsmith77 lsmith77 mentioned this pull request Sep 25, 2013
Merged
@lsmith77
Copy link
Member

closing in favor of #188

@lsmith77 lsmith77 closed this Sep 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants