Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getTransactionManager() moved to Workspace #22

Merged
merged 4 commits into from
Jul 26, 2011

Conversation

starkj
Copy link

@starkj starkj commented Jul 25, 2011

No description provided.

@dbu
Copy link
Member

dbu commented Jul 25, 2011

i just merged the pull request to phpcr. can you please add here the updated phpcr submodule? otherwise session will not conform to SessionInterface when i merge this.

@beberlei
Copy link
Member

Is this different from how jcr handles transactions or why is the method moved?

@starkj
Copy link
Author

starkj commented Jul 25, 2011

JCR does not specify where to get the TransactionManager from.
It's just moved so all *Managers (Lock, Version, Transaction, ...) are available through Workspace

@dbu
Copy link
Member

dbu commented Jul 26, 2011

@beberlei: jcr refers to the JTA java standard. in php there is no generic transaction standard, so we do "our own" for phpcr and have to hook it somewhere. and workspace is the more consistent place for that.

dbu added a commit that referenced this pull request Jul 26, 2011
getTransactionManager() moved to Workspace
@dbu dbu merged commit c237d70 into jackalope:master Jul 26, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants