Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to compile with --mixed #39

Closed
kris7t opened this issue Jul 20, 2013 · 1 comment
Closed

Impossible to compile with --mixed #39

kris7t opened this issue Jul 20, 2013 · 1 comment

Comments

@kris7t
Copy link

kris7t commented Jul 20, 2013

This is probably a pretty well-known issue, I've seen it in the mailing list archives, but there was no respose. Issue #21 was partially about this, however, its fix ad01143 did not solve it, despite the claim.

The main problem is that the lib32 clientlib is created by common/wscript with

if bld.env['BUILD_WITH_32_64']:
    print("create 32bit lib...")
    clientlib32bit = clientlib.clone('lib32')

which, some bisecting show, under waf 1.5 (with the help of the relevant section in the configure method) compiled the needed object files and binary into build/lib32. However, under waf 1.6, these object files end up in the build/ directory directly, overwriting the 64-bit object files. Thus linking of the 64-bit clientlib fails, because the wscript wants to link 32-bit objects into a 64-bit shared library.

@kris7t
Copy link
Author

kris7t commented Jul 21, 2013

I managed to build by adding the following lines to the if statement's body I quoted in the issue:

clientlib32bit.variant = 32
clientlib32bit.name = 'clientlib32'
clientlib32bit.target = 'lib32/jack'

The variant parameter appends 32 to the name of any object files, so that they don't get overwritten; the name change avoids linking the clients build by the build system with the 32-bit library; and the target puts the resulting shared library to a different directory, so it does not overwrite the 64-bit one. It sill installs to the right directory.

I don't know whether I should send a pull request with this, it seems very hackish (and trivial). I think the wscript should be fixed to output 32-bit binaries to build/lib32, although I don't know how to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant